-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] delete file #1122
[api] delete file #1122
Conversation
b31bc38
to
446a1ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I have only some minor comments
Great comments @kostas-kou ! Fixed most of them in 92903a6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Especially on the tests, very extensive.
I don't have any significant remark on the PR.
353261a
to
3ac7e5e
Compare
@kostas-kou and @pahatz, thanks for your reviews! I have fixed the weird comment, rebased on main and also rebased to get rid of the fixup-commits. Only 3ac7e5e is new, the rest is the same as when you reviewed. |
...and added 8a745c4 for the rbac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested, but it looks good. Tiny minor comments :-)
8a745c4
to
0f445c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More specific comments are coming
109e7e2
to
d690e54
Compare
Co-authored-by: Joakim Bygdell <[email protected]>
4821ce0
to
5640d72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Related issue(s) and PR(s)
This PR closes #1134 .
Description
This PR adds the delete file functionality to the
api
component. Specifically, it deletes the file from the inbox and it adds a new file log event, setting the file status todisabled
.Also, it adds the
fileID
to thelist
functionality of theapi
, since that field is needed in order to delete a file:How to test
make build-all
thenPR_NUMBER=$(date +%F) docker compose -f .github/integration/sda-s3-integration.yml run integration_test
.List the files (eg with
http://localhost:8090/users/[email protected]/files
) and make sure files in the inbox can be deleted, and that archived files can not be deleted.